fix: Filter only self when elaborating impl_super_outlives
#149315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Contributor
|
So I think this one is fine after thinking about it for a bit, even if I am still somewhat uncomfortable with this change. Regardless of whether this is sound, it does not work once we want to support coinductive traits as we will need to check all super trait bounds at this point. I generally think that the underlying issue of the search graph perf hack in rust-lang/trait-system-refactor-initiative#257 (comment) will also affect other code snippets I would like to remove that perf hack and look into other optimizations and fast paths which don't negatively impact behavior |
lcnr
added
S-waiting-on-author
Member
Author
|
Okay, in any case, this doesn't seem to be a preferable fix, especially regarding coinductive traits. I'll close this and look for otherwise like that perf hack |
rustbot
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/trait-system-refactor-initiative#257
Seems that considering super outlives bounds only on self type is enough for preventing unsoundnesses like in #98117
r? lcnr